Remove unused nccd node-fetch (#76241)

This vendored packaged is no longer needed as we removed the last usage of it. x-ref: #75741
vercel · Feb 20, 2025 · d1c9aec · d1c9aec
1 parent 47f3500
commit d1c9aec
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 14 deletions.
diff --git a/packages/next/src/compiled/@ampproject/toolbox-optimizer/index.js b/packages/next/src/compiled/@ampproject/toolbox-optimizer/index.js
diff --git a/packages/next/src/compiled/node-fetch/index.js b/packages/next/src/compiled/node-fetch/index.js
diff --git a/packages/next/src/compiled/node-fetch/package.json b/packages/next/src/compiled/node-fetch/package.json
diff --git a/packages/next/taskfile.js b/packages/next/taskfile.js
@@ -60,7 +60,6 @@ const externals = {
   'caniuse-lite': 'caniuse-lite',
   '/caniuse-lite(/.*)/': 'caniuse-lite$1',
 
-  'node-fetch': 'node-fetch',
   postcss: 'postcss',
   // Ensure latest version is used
   'postcss-safe-parser': 'next/dist/compiled/postcss-safe-parser',
@@ -241,15 +240,6 @@ export async function copy_vercel_og(task, opts) {
   )
 }
 
-// eslint-disable-next-line camelcase
-externals['node-fetch'] = 'next/dist/compiled/node-fetch'
-export async function ncc_node_fetch(task, opts) {
-  await task
-    .source(relative(__dirname, require.resolve('node-fetch')))
-    .ncc({ packageName: 'node-fetch', externals })
-    .target('src/compiled/node-fetch')
-}
-
 externals['anser'] = 'next/dist/compiled/anser'
 externals['next/dist/compiled/anser'] = 'next/dist/compiled/anser'
 export async function ncc_node_anser(task, opts) {
@@ -2310,7 +2300,6 @@ export async function ncc(task, opts) {
         'ncc_image_size',
         'ncc_hapi_accept',
         'ncc_commander',
-        'ncc_node_fetch',
         'ncc_node_anser',
         'ncc_node_stacktrace_parser',
         'ncc_node_data_uri_to_buffer',

diff --git a/test/e2e/next-font/index.test.ts b/test/e2e/next-font/index.test.ts
@@ -72,6 +72,10 @@ describe('next/font', () => {
     })
   }
 
+  it('should not have deprecation warning', async () => {
+    expect(next.cliOutput.toLowerCase()).not.toContain('deprecation')
+  })
+
   describe('import values', () => {
     test('page with font', async () => {
       const html = await renderViaHTTP(next.url, '/with-fonts')

diff --git a/test/integration/amphtml/test/index.test.js b/test/integration/amphtml/test/index.test.js
@@ -60,6 +60,10 @@ describe('AMP Usage', () => {
       return killApp(app)
     })
 
+    it('should not have deprecation warning', async () => {
+      expect(output.toLowerCase()).not.toContain('deprecation')
+    })
+
     it('should have amp optimizer in trace', async () => {
       const trace = JSON.parse(
         readFileSync(join(appDir, '.next/next-server.js.nft.json'), 'utf8')