fix error tests

vercel · Jan 24, 2025 · 2ee55d2 · 2ee55d2
1 parent c3a4497
commit 2ee55d2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/packages/next/next_runtime.config.js b/packages/next/next_runtime.config.js
@@ -97,8 +97,6 @@ const externalsMap = {
 
 const externalsRegexMap = {
   '(.*)trace/tracer$': 'next/dist/server/lib/trace/tracer',
-  '(.*)/dist/compiled/babel/(.*)': '$1/dist/compiled/babel/$1',
-  '(.*)/dist/compiled/webpack/(.*)': '$1/dist/compiled/webpack/$1',
 }
 
 const bundleTypes = {
@@ -130,6 +128,11 @@ const bundleTypes = {
 module.exports = ({ dev, turbo, bundleType, experimental }) => {
   const externalHandler = ({ context, request, getResolve }, callback) => {
     ;(async () => {
+      if (request.match(/next[/\\]dist[/\\]compiled[/\\](babel|webpack)/)) {
+        callback(null, 'commonjs ' + request)
+        return
+      }
+
       if (request.endsWith('.external')) {
         const resolve = getResolve()
         const resolved = await resolve(context, request)

diff --git a/test/e2e/react-compiler/react-compiler.test.ts b/test/e2e/react-compiler/react-compiler.test.ts
@@ -92,6 +92,7 @@ describe.each(
       expect(cliOutput).toContain(
         '' +
           "\n ⨯ TypeError: Cannot read properties of undefined (reading 'H')" +
+          '\n    at c (**)' +
           // location not important. Just that this is the only frame.
           // TODO: Stack should start at product code. Possible React limitation.
           '\n    at Container (**)' +

diff --git a/test/integration/server-side-dev-errors/test/index.test.js b/test/integration/server-side-dev-errors/test/index.test.js
@@ -218,18 +218,12 @@ describe('server-side dev errors', () => {
       if (isTurbopack) {
         expect(stderrOutput).toContain(
           ' ⨯ ReferenceError: missingVar is not defined' +
-            '\n    at handler (../../test/integration/server-side-dev-errors/pages/api/hello.js:2:2)' +
-            // Next.js internal frame. Feel free to adjust.
-            // Not ignore-listed because we're not in an isolated app and Next.js is symlinked so it's not in node_modules
-            '\n    at async'
+            '\n    at handler (../../test/integration/server-side-dev-errors/pages/api/hello.js:2:2)'
         )
       } else {
         expect(stderrOutput).toStartWith(
           '⨯ ReferenceError: missingVar is not defined' +
-            '\n    at handler (../../test/integration/server-side-dev-errors/pages/api/hello.js:2:2)' +
-            // Next.js internal frame. Feel free to adjust.
-            // Not ignore-listed because we're not in an isolated app and Next.js is symlinked so it's not in node_modules
-            '\n    at async'
+            '\n    at handler (../../test/integration/server-side-dev-errors/pages/api/hello.js:2:2)'
         )
       }
       expect(stderrOutput).toContain(