When.js failing test

[guybedford]

When defines itself using the wrapper pattern:

(function(define) { 'use strict';
define(function (require) {

	var timed = require('./lib/decorators/timed');
	var array = require('./lib/decorators/array');
	var flow = require('./lib/decorators/flow');
	var fold = require('./lib/decorators/fold');
	var inspect = require('./lib/decorators/inspect');
});
})(typeof define === 'function' && define.amd ? define : function (factory) { module.exports = factory(require); });

Similarly to #87 we have the static analysis problem of not knowing that the internal requires are external requires... (although in theory this static analysis is a trivial compiler problem :P).

This seems to be the bug behind "jugglingdb" builds as far as I can tell.

[guybedford]

One suggested fix for the above would be to "statically detect" these AMD-style wrappers, and "unwrap" them in a loader before passing back to Webpack for analysis.

[rauchg]

I was just about to create a jugglingdb failing test, but it's this! :)

[guybedford]

I've added the fix for this case, based on a very specific wrapper detection.

While the code is highly overly-specific, I think there will be ways to generalize the approach to better analysis methods as it expands, but i think as a starting point starting specific then moving to more general analysis makes sense, driven by the test cases.

[codecov-io]

Codecov Report

Merging #92 into master will increase coverage by 1.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   69.78%   70.84%   +1.05%     
==========================================
  Files           3        3              
  Lines         331      343      +12     
==========================================
+ Hits          231      243      +12     
  Misses        100      100

Impacted Files	Coverage Δ
src/asset-relocator.js	92.68% <100%> (+0.45%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da037bd...40b6eaa. Read the comment docs.

[rauchg]

@guybedford can you:

• fix the conflict
• write up an issue with the more general solution description
  ?

[guybedford]

Posted #95 which would replace a lot of the logic with a partial evaluator.