Update to webpack-asset-relocator-loader@0.3.2 #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the other one - vercel/webpack-asset-relocator-loader#7. |
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=======================================
Coverage 69.04% 69.04%
=======================================
Files 12 12
Lines 378 378
=======================================
Hits 261 261
Misses 117 117Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the updates for correct parser errors, the express templates support, as well as firebase admin support.
We have tests for all the above in the asset relocator loader itself, although the firebase-admin case is not a full integration test as that would involve storing credentials.
Fixes #317
Fixes #323