Update browserify wrapper handling #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
=======================================
Coverage 68.37% 68.37%
=======================================
Files 12 12
Lines 370 370
=======================================
Hits 253 253
Misses 117 117Continue to review full report at Codecov.
|
|
@guybedford Thanks! Can you add an integration test for |
styfle
requested changes
Mar 14, 2019
|
The test is a unit test in the asset relocator loader. My hesitation with
adding full integration tests for everything is we end up with a 10 minute
test script, but I get the arguments for that too.
…On Thu, 14 Mar 2019 at 21:49, Steven ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Let's make sure this has a integration test for tiny-json-http so we
don't regress
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#311 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAkiyvxO5MBhQoVrOaifqJJNGdBM9avxks5vWqfkgaJpZM4b1Dqn>
.
|
|
+1 on integration test |
|
Sure, I've added an integration test here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the update to the asset relocator loader to improve the Browserify wrapper handling (vercel/webpack-asset-relocator-loader@2d0e7c7).
Specifically we extend the browserify wrapper detection to be able to detect the uglification of the wrapper, as well as ensuring that the require detection is converted to apply to
__non_webpack_require__.Fixes #299.