Ensure that any __non_webpack_require__ is retained in subsequent builds #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an interesting one, basically when an ncc build is again built, any instances of the following pattern:
will be converted into:
by Webpack. And as a result the pattern breaks on the second build.
Fixed by injecting a phase before that avoids this double rewriting.
//cc @sokra this seems to be a breakdown in build transitivity in Webpack.