Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically include sourcemap-register in source map builds #270

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

guybedford
Copy link
Contributor

This implements #180 including the sourcemap-register.js file as an asset of any ncc build -s call (it's 122KB). The build file is then updated to require this file first to provide source map support in Node.js for any execution errors.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@bfe57db). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #270   +/-   ##
=========================================
  Coverage          ?   74.35%           
=========================================
  Files             ?       17           
  Lines             ?      889           
  Branches          ?        0           
=========================================
  Hits              ?      661           
  Misses            ?      228           
  Partials          ?        0
Impacted Files Coverage Δ
src/cli.js 59.61% <ø> (ø)
src/index.js 69.86% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe57db...f85c845. Read the comment docs.

@rauchg rauchg merged commit 0a9014e into master Feb 1, 2019
@rauchg rauchg deleted the build-sourcemap branch February 1, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants