Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up sourcemap #269

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Clean up sourcemap #269

merged 1 commit into from
Feb 1, 2019

Conversation

guybedford
Copy link
Contributor

This cleans up the source map output such that instead of getting:

/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/d41d8cd98f00b204e9800998ecf8427e/webpack:/test.js:4
throw new Error('test');
^
Error: test
    at Object.294 (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/d41d8cd98f00b204e9800998ecf8427e/webpack:/test.js:4:1)
    at __webpack_require__ (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/d41d8cd98f00b204e9800998ecf8427e/webpack:/webpack/bootstrap:19:1)
    at startup (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/d41d8cd98f00b204e9800998ecf8427e/webpack:/webpack/bootstrap:33:1)
    at /private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/d41d8cd98f00b204e9800998ecf8427e/webpack:/webpack/bootstrap:37:1
    at Object.<anonymous> (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/d41d8cd98f00b204e9800998ecf8427e/index.js:43:10)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)

we will now get:

/test.js:4
throw new Error('test');
^
Error: test
    at Object.294 (/test.js:4:1)
    at __webpack_require__ (/webpack:bootstrap:19:1)
    at startup (/webpack:bootstrap:33:1)
    at /webpack:bootstrap:37:1
    at Object.<anonymous> (/private/var/folders/bm/grflgmxs62g01cd9m8sjjm740000gn/T/d41d8cd98f00b204e9800998ecf8427e/index.js:43:10)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
    at Function.Module._load (internal/modules/cjs/loader.js:530:3)

@codecov-io
Copy link

Codecov Report

Merging #269 into master will increase coverage by 0.26%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   74.23%   74.49%   +0.26%     
==========================================
  Files          17       17              
  Lines         885      898      +13     
==========================================
+ Hits          657      669      +12     
- Misses        228      229       +1
Impacted Files Coverage Δ
src/index.js 70.96% <92.3%> (+1.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61dcf6c...6d52b7c. Read the comment docs.

@rauchg rauchg merged commit 11f64a2 into master Feb 1, 2019
@rauchg rauchg deleted the clean-up-sourcemap branch February 1, 2019 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants