Conditional menu build fix for window #1903
Conversation
|
@Stanzilla You can test it. |
|
Fixes it! |
| @@ -12,7 +12,6 @@ const darwinMenu = require('./menus/darwin'); | |||
| module.exports = (createWindow, updatePlugins) => { | |||
| const commands = getKeymaps().commands; | |||
| const menu = [ | |||
| (process.platform === 'darwin' ? darwinMenu(commands) : []), | |||
There was a problem hiding this comment.
...(process.platform === 'darwin' ? [darwinMenu(commands)] : []),
There was a problem hiding this comment.
you copy pasted it wrong 😉 #1876 (comment)
There was a problem hiding this comment.
oh my comment was wrong too :D
...(process.platform === 'darwin' ? [darwinMenu(commands)] : []), this should work
There was a problem hiding this comment.
I tried (process.platform === 'darwin' ? [darwinMenu(commands)] : []), and it still causes a blank menu entry on Windows
There was a problem hiding this comment.
you should keep '...' in the beginning to destructure (possible empty) array.
There was a problem hiding this comment.
oh! that makes it work indeed
|
Nice @chabou @ppot @Stanzilla 💯 ' |
* use speard for menu building
No description provided.