Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cookies() .set() reflect priority attribute into set-cookie #640

Merged
merged 4 commits into from
Oct 15, 2023

Conversation

renchris
Copy link
Contributor

Closes vercel/next.js#56848

This PR provides the fix for cookies() .set() to reflect the priority attribute into set-cookie

RE: @balazsorban44's comment and request change on vercel/next.js#56850 Pull Request:

"Thanks for the PR, the @edge-runtime/cookies package is an upstream dependency, meaning it should be addressed there first, could you open these changes there, so we can bump the package here to incorporate it?

See https://github.com/vercel/edge-runtime/blob/main/packages/cookies/src/serialize.ts#L16"

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2023

🦋 Changeset detected

Latest commit: 6458788

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@edge-runtime/cookies Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
edge-runtime ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 2:07am

@balazsorban44
Copy link
Member

Thanks, @renchris, could you run pnpm changeset in the root of the repo and follow the instructions? This can be a patch, so you'll end up with something like

@renchris
Copy link
Contributor Author

Thanks, @renchris, could you run pnpm changeset in the root of the repo and follow the instructions? This can be a patch, so you'll end up with something like

Okay, I ran the pnpm changesetcommand in the root of the repo and follow the instructions. I commited the returned markdown being at edge-runtime/.changeset/fifty-eagles-invite.md

---
'@edge-runtime/cookies': patch
---

fix cookies() .set() to reflect the priority attribute into set-cookie

@Kikobeats Kikobeats merged commit 5a8f35a into vercel:main Oct 15, 2023
@github-actions github-actions bot mentioned this pull request Oct 15, 2023
timneutkens pushed a commit to vercel/next.js that referenced this pull request Oct 16, 2023
It bumps Edge Runtime to include the latest fixes, such as:

- vercel/edge-runtime#622
- vercel/edge-runtime#640

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookies() does not reflect .set() priority attribute into set-cookie
3 participants