Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace CircleCI config with GH Actions CI workflow #55

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Replace CircleCI config with GH Actions CI workflow #55

merged 4 commits into from
Jan 17, 2025

Conversation

aharpervc
Copy link
Contributor

@aharpervc aharpervc commented Jan 16, 2025 •
edited
Loading

Todo

  • add GH Actions CI workflow
    • while we're here, add additional Ruby versions to the CI list
  • remove CircleCI config file
    • stop CircleCI project
  • update repo branch protection rules

Notes

(reminder: this is a public repository)

@aharpervc aharpervc self-assigned this Jan 16, 2025
@aharpervc aharpervc force-pushed the add-gh-actions-ci-workflow branch 2 times, most recently from 54da8c4 to a16ad2d Compare January 16, 2025 16:30
@aharpervc
Replace CircleCI config with GH Actions CI workflow
ed30d07
@aharpervc
Fix Gemspec/DevelopmentDependencies
ba907b3 
- this also fixes the development/test gems not installing w/ setup-ruby, and then the CI workflow failing due to missing rspec
@aharpervc
Fix Diplomat error due to un-required ostruct dependency
ffd67ab
@aharpervc aharpervc force-pushed the add-gh-actions-ci-workflow branch from 2d2a5c8 to ffd67ab Compare January 16, 2025 16:54
@aharpervc aharpervc marked this pull request as ready for review January 16, 2025 17:04
@aharpervc aharpervc requested a review from a team as a code owner January 16, 2025 17:04
@aharpervc aharpervc enabled auto-merge January 16, 2025 17:09
@aharpervc aharpervc force-pushed the add-gh-actions-ci-workflow branch from a89a0cf to 3d68003 Compare January 16, 2025 17:10
@aharpervc aharpervc merged commit f25ed3c into master Jan 17, 2025
9 checks passed
@aharpervc aharpervc deleted the add-gh-actions-ci-workflow branch January 17, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julrocas julrocas julrocas approved these changes

Assignees

@aharpervc aharpervc

Labels
needs-review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aharpervc @julrocas