-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the parser compatible with EBCDIC plaforms like z/OS #377
Conversation
…at can be used instead).
…rsations from byte[] to String and vice versa.
Codecov Report
@@ Coverage Diff @@
## integration #377 +/- ##
=================================================
+ Coverage 25.2% 25.23% +0.03%
Complexity 877 877
=================================================
Files 232 231 -1
Lines 12816 12800 -16
Branches 1829 1829
=================================================
Hits 3230 3230
+ Misses 9208 9192 -16
Partials 378 378
Continue to review full report at Codecov.
|
…(required for EBCDIC platforms).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main changes looks ok, but it looks like the org.verapdf.cos.visitor.Writer class has been affected by some sort of auto formatting. The result has not the same code style as all other classes in veraPDF. So, can you, please, update the branch and remove code style changes for that class. Thank you.
I've reverted back to the original coding conventions. Please review again, Thank you. |
@michaelknigge Thanks a lot for your PR. All changes will be added in our code soon, but I will close this PR and the reasons will be described in veraPDF/veraPDF-library#1032 |
The Greenfield parser assumes that it runs on ASCII platforms and for this reason does not provide information about the charset that is to be used for byte[] to String (and vice versa) conversations. Java then uses the charset that is specified by the system property file.encoding.
On z/OS (i.e.) file.encoding might be IBM-500 (EBCDIC-International) and then the parser converts a read byte[] to a String using this charset...