Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the parser compatible with EBCDIC plaforms like z/OS #377

Closed
wants to merge 6 commits into from
Closed

Make the parser compatible with EBCDIC plaforms like z/OS #377

wants to merge 6 commits into from

Conversation

michaelknigge
Copy link

The Greenfield parser assumes that it runs on ASCII platforms and for this reason does not provide information about the charset that is to be used for byte[] to String (and vice versa) conversations. Java then uses the charset that is specified by the system property file.encoding.

On z/OS (i.e.) file.encoding might be IBM-500 (EBCDIC-International) and then the parser converts a read byte[] to a String using this charset...

Michael Knigge added 2 commits July 19, 2019 11:48
@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #377 into integration will increase coverage by 0.03%.
The diff coverage is 12.12%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #377      +/-   ##
=================================================
+ Coverage           25.2%   25.23%   +0.03%     
  Complexity           877      877              
=================================================
  Files                232      231       -1     
  Lines              12816    12800      -16     
  Branches            1829     1829              
=================================================
  Hits                3230     3230              
+ Misses              9208     9192      -16     
  Partials             378      378
Impacted Files Coverage Δ Complexity Δ
...ava/org/verapdf/pd/font/cff/CFFFileBaseParser.java 75% <ø> (ø) 23 <0> (ø) ⬇️
src/main/java/org/verapdf/cos/visitor/Writer.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/org/verapdf/tools/EncryptionToolsRevision4.java 0% <0%> (ø) 0 <0> (ø) ⬇️
src/main/java/org/verapdf/cos/COSStream.java 22.15% <0%> (ø) 7 <0> (ø) ⬇️
src/main/java/org/verapdf/pd/colors/PDIndexed.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/org/verapdf/pd/font/type1/PDType1Font.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../main/java/org/verapdf/parser/SignatureParser.java 0% <0%> (ø) 0 <0> (ø) ⬇️
src/main/java/org/verapdf/cos/COSString.java 13.79% <0%> (+0.45%) 8 <0> (ø) ⬇️
...main/java/org/verapdf/pd/font/cmap/CMapParser.java 48.36% <0%> (ø) 28 <0> (ø) ⬇️
...va/org/verapdf/pd/font/type1/Type1FontProgram.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a438080...37651ea. Read the comment docs.

@carlwilson carlwilson requested a review from BezrukovM July 24, 2019 00:23
Copy link
Contributor

@BezrukovM BezrukovM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main changes looks ok, but it looks like the org.verapdf.cos.visitor.Writer class has been affected by some sort of auto formatting. The result has not the same code style as all other classes in veraPDF. So, can you, please, update the branch and remove code style changes for that class. Thank you.

@michaelknigge
Copy link
Author

I've reverted back to the original coding conventions. Please review again, Thank you.

@BezrukovM
Copy link
Contributor

@michaelknigge Thanks a lot for your PR. All changes will be added in our code soon, but I will close this PR and the reasons will be described in veraPDF/veraPDF-library#1032

@BezrukovM BezrukovM closed this Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants