Fix/Change: STATIC_QUEUE declares type rather than variable #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old behavior of STATIC_QUEUE macro was to define a variable. This is all nice and compact, but scales poorly if you need to access the queue from more than one compilation unit. Thus this macro has been changed to macro STATIC_QUEUE_T which declares a type instead of variable. Thus the variable has to be defined by the developer. The advantage of this approach is that you can declare the queue type in a header and then define / extern variables as needed in modules. This is a breaking change for all the code which was already relying on STATIC_QUEUE. In order to reveal such code early, we don't provide macro for backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behavior of STATIC_QUEUE macro was to define a variable. This is all nice and compact, but scales poorly if you need to access the queue from more than one compilation unit.
Thus this macro has been changed to macro STATIC_QUEUE_T which declares a type instead of variable. Thus the variable has to be defined by the developer.
The advantage of this approach is that you can declare the queue type in a header and then define / extern variables as needed in modules.
This is a breaking change for all the code which was already relying on STATIC_QUEUE.
In order to reveal such code early, we don't provide macro for backwards compatibility.