Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): all Arabic tokens translated (100%) #2287

Merged
merged 3 commits into from
Jul 18, 2023
Merged

fix(admin-ui): all Arabic tokens translated (100%) #2287

merged 3 commits into from
Jul 18, 2023

Conversation

wpplumber
Copy link
Contributor

@tarik I created the branch admin-ui-rtl (https://github.com/vendure-ecommerce/vendure/tree/admin-ui-rtl) which has the basic parts wired up, and the 2 main tasks that would need to be done are:

Add all the AR translation strings
Update CSS to display property in RTL. The main task would be to replace instances of margin-left and margin-right etc with the RTL-safe equivalents like margin-inline-start etc. This is covered well here: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_logical_properties_and_values

⬆️ by @michaelbromley

Part one done:

  • Add all the AR translation strings

@netlify
Copy link

netlify bot commented Jul 15, 2023

Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit 89fc652
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/64b5137c2aeeb300088503c1

@wpplumber
Copy link
Contributor Author

Why getting the following issue?

image

@michaelbromley
Copy link
Member

I failed to add an isRTL() method to the mock i18n service.

it should be sufficient to add

isRTL(): boolean {
  return false;
}

to the class in i18n.service.mock.ts file.

@wpplumber
Copy link
Contributor Author

Thank you, Michael.

@wpplumber
Copy link
Contributor Author

I see the previous failure passed but now other one with mysql!

@michaelbromley
Copy link
Member

Don't worry - that failing e2e test suite is not related to your changes. Sometimes the e2e tests are a bit flaky because there are so many moving parts.

Do you also plan to incorporate the CSS changes in this PR or are you planning that in a separate PR?

@wpplumber
Copy link
Contributor Author

I prefer in other PR which makes it simple as possible.

I went through reading the clarity.design foundation but to avoid more time learning I plan to overwrite css styles which makes better UX i.e font size, margin between icon and text ...

@michaelbromley michaelbromley merged commit 83ecec9 into vendure-ecommerce:master Jul 18, 2023
@michaelbromley
Copy link
Member

OK, thanks so much for your work so far!

@wpplumber
Copy link
Contributor Author

Thank you too for helping in getting my first contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants