-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(admin-ui): all Arabic tokens translated (100%) #2287
fix(admin-ui): all Arabic tokens translated (100%) #2287
Conversation
✅ Deploy Preview for effervescent-donut-4977b2 canceled.
|
I failed to add an it should be sufficient to add isRTL(): boolean {
return false;
} to the class in i18n.service.mock.ts file. |
Thank you, Michael. |
I see the previous failure passed but now other one with mysql! |
Don't worry - that failing e2e test suite is not related to your changes. Sometimes the e2e tests are a bit flaky because there are so many moving parts. Do you also plan to incorporate the CSS changes in this PR or are you planning that in a separate PR? |
I prefer in other PR which makes it simple as possible. I went through reading the clarity.design foundation but to avoid more time learning I plan to overwrite css styles which makes better UX i.e font size, margin between icon and text ... |
OK, thanks so much for your work so far! |
Thank you too for helping in getting my first contribution. |
⬆️ by @michaelbromley
Part one done:
Add all the AR translation strings