OrderLine ID is undefined on OrderLineEvent deleted event

[lzzfnc]

Describe the bug
Hello! I'm writing a plugin to do some operations with the id of an OrderLine once it's removed from an order. I'm using the EventBus to filter the events and get only the ones where event.type === 'deleted'. In the subscribe function however, the orderLine id is undefined. Is this the expected behaviour or I'm missing something?

To Reproduce
Steps to reproduce the behavior:

1. Use the event bus to subscribe to OrderLineEvents
2. Log OrderLines
3. When event.type is created or updated the id is present
4. When event.type is deleted the id is undefined

Expected behavior
To be able to access the id before the cancellation of an OrderLine

Environment (please complete the following information):

• @vendure/core version: 2.1.3
• Nodejs version 18
• Database (mysql/postgres etc): postgres

[michaelbromley]

Hi, this is a peculiarity with TypeORM that seems to mutate the object upon calling the .remove() method on an entity. It was generally addressed for other events with this commit: 265bb15, but I overlooked the OrderLineEvent at the time.

[lzzfnc]

I see, thanks! Do you want me to send a PR for that?

[michaelbromley]

I'm in the process of fixing, but thanks for the offer. :)

When I tried to fix in the same way as the linked commit, it revealed an underlying issue that also needs fixing at the same time.

[lzzfnc]

Super, thanks a lot then!