Fix(evm-block-recovery): Load block ids by small chunks. #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vldm
reviewed
Aug 22, 2022
| start_slot, limit | ||
| ))?; | ||
| let mut start_slot = start_slot; | ||
| let mut limit = (end_slot - start_slot) as usize; |
| pub async fn find_native(ledger: LedgerStorage, start_slot: u64, limit: usize) -> Result<()> { | ||
| log::info!("Looking for missing Native Blocks. start slot {start_slot}, limit {limit}"); | ||
| pub async fn find_native(ledger: LedgerStorage, start_slot: u64, end_slot: u64) -> Result<()> { | ||
| const LOAD_CHUNK_SIZE: usize = 500_000; |
There was a problem hiding this comment.
can you add metrics info for this constant:
- How much data bigtable produce in response?
- How long bigtable process request?
- How long local cpu process this chunk?
- What cpu is used vendor/clock.
vldm
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.