Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(velas-chain): Downgrade Rust toolchain and CI environment to version 1.54. #244

Closed
wants to merge 1 commit into from

Conversation

Tirka
Copy link
Collaborator

@Tirka Tirka commented Nov 24, 2021

Problem

Recent updates to Cargo (1.55+) caused problems with environment variables in build.rs scripts.
Related issue: rust-lang/cargo#10111

Summary of Changes

Temporary downgrade toolchain version and CI environment to Rust stable 1.54 until clarification of the new behavior

@hrls
Copy link
Contributor

hrls commented Nov 24, 2021

Maybe we can patch dependent library to read value of CARGO_BUILD_RUSTFLAGS instead of RUSTFLAGS?

image

@Tirka
Copy link
Collaborator Author

Tirka commented Nov 24, 2021

We could use the existing CARGO_RUSTFLAGS_ENCODED env var. I will prepare an appropriate pull request to https://github.com/darrenldl/reed-solomon-erasure if Cargo 1.55+ behavior is confirmed as correct

@Tirka
Copy link
Collaborator Author

Tirka commented Dec 12, 2021

Cargo team confirmed this is a breaking change and added notes to the changelog. Closed.

@Tirka Tirka closed this Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants