Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new expressions to allowed types #863

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

jgautier-dd
Copy link
Contributor

Description

When creating a new type definition from an interface mocks were not being generated due to the list of types allowed in the Visit function in parser.go.

When the type definition is from an interface in the same package the type is *ast.Ident and if the interface is from a different package the type is *ast.SelectorExpr.

  • Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Version of Go used when building/testing:

  • 1.22
  • 1.23

How Has This Been Tested?

Everything has been tested via the unit test(s).

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@LandonTClipp
Copy link
Collaborator

Thank you for the PR! This looks essentially perfect. Kind of annoying that we have to whitelist the expressions in this way, but I have not conceived of a better method as of yet.

@LandonTClipp LandonTClipp merged commit ede4f2c into vektra:master Dec 24, 2024
4 checks passed
@RangelReale RangelReale mentioned this pull request Jan 2, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants