Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge bind-simmat branch to master: adding new function smbind #175

Merged
merged 27 commits into from
May 24, 2016

Conversation

psolymos
Copy link
Contributor

The new function smbind is related to issue #164 works as expected. Examples cover the use cases and results are as expected. Also fixes some issues with start/end/thin values in as.ts.oecosimu, simulate.nullmodel, and update.nullmodel.

This was referenced May 20, 2016
@jarioksa
Copy link
Contributor

jarioksa commented May 23, 2016

I have run some tests stratifying species by taxonomy, and everything seems to work fine. The usage requires some familiarity with R intricacies, though. Perhaps permatswap or permatfull interface could be used to make stratifying easier.

So far my only comment is that you should not reset RNG in the user session. This would happen with example(nullmodel). I have suggested a change to this in daad496. This is similar as in man/orditorp.Rd, and it would be still better to save the state of RNG and reset to it on.exit() (in both cases).

It is a question of taste, but I do prefer to have real data sets in examples instead of simulated ones.

@psolymos
Copy link
Contributor Author

psolymos commented May 24, 2016

I have no problem with changing the matrix to data(dune); x <- as.matrix(mite) or something similar in example(nullmodel). That would address both the seed reset issue and preference towards real data sets.

I merge this branch and follow up with the example and null model error messages as references in #177

@psolymos psolymos merged commit 9e42f3f into master May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants