Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLAS/LAPACK calls in R 4.2.0 #447

Closed
jarioksa opened this issue Nov 23, 2021 · 2 comments
Closed

BLAS/LAPACK calls in R 4.2.0 #447

jarioksa opened this issue Nov 23, 2021 · 2 comments
Labels
CRAN trouble fixed

Comments

@jarioksa
Copy link
Contributor

jarioksa commented Nov 23, 2021 •
edited
Loading

Brian Ripley wrote on 25 Sep 2021:

CRAN package not using USE_FC_LEN_T

This is a mechanism introduced in R 3.6.2 to change the C/C++ prototypes of BLAS and LAPACK functions to correspond to code produced by gfortran >= 7. Now that compiler is in near-universal use, it is planned to make its use obligatory in R 4.2.0, with the switch in R-devel in early November.

The documentation is in `Writing R Extensions' §6.6.2, https://cran.r-project.org/doc/manuals/r-devel/R-exts.html#Fortran-character-strings . Note the caveats: USE_FC_LEN_T has to be defined before any R headers are included.

This is early notification: please amend your packages at the next update (which several of you have been asked for). We will remind you near the change.

This seems not have happened yet on 23 Nov 2021, but we must be prepared, and therefore I added this reminder as an issue.

We have direct calls (F77_CALL()) to LAPACK/BLAS functions in getF.c.
gavinsimpson added a commit to gavinsimpson/vegan that referenced this issue Mar 1, 2022
@gavinsimpson
add a check run for 3.6, which should catch any problems with potenti…
a4d88a7 
…al changes we need to make to fortran calls from 4.2 as per vegandevs#447
gavinsimpson added a commit to gavinsimpson/vegan that referenced this issue Mar 1, 2022
@gavinsimpson
add the required fixes to address upcoming problem of vegandevs#447 w…
83a7003 
…hile maintaining ability to run on R >= 3.4.0 even though USE_FC_LEN_T only appeard in 3.6.2
@gavinsimpson
Copy link
Contributor

PR #496 provides a(n attempted) fix for this, which if accepted/merged, can be ported to the 2.5 branch if we don't have a vegan release before R 4.2 is released

gavinsimpson added a commit that referenced this issue Mar 9, 2022
@gavinsimpson
Merge pull request #496 from gavinsimpson/issue-447
413f8df 
Changes to address upcoming problem of #447 and USE_FC_LEN_T
@gavinsimpson
Copy link
Contributor

This is now handled via 413f8df

@jarioksa jarioksa mentioned this issue Mar 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CRAN trouble fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gavinsimpson @jarioksa