Fixes for 1.1.0rc2 #255
Merged
Fixes for 1.1.0rc2 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- icu is bundled with the Python duckdb library, so it doesn't need to be installed - Only install and load httpfs when constructing the duckdb connection internalls (not when the connection is passed in), and convert extension install/load exceptions into a warning.
This way a geopandas GeoDataFrame is treated as a geointerface object rather than a pandas DataFrame
fallback to 17.9.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc fixes to 1.1.0rc1:
DuckDB extension refinements:
Actually fix #250 by handling geo interface objects before checking if they are Pandas DataFrames.