feat: add config.numberFormatType for using custom formatter with config.numberFormat
#8228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da778ec to
cbcb045
Compare
kanitw
commented
Jun 16, 2022
src/compile/format.ts
Outdated
| @@ -121,7 +138,11 @@ export function formatCustomType({ | |||
| }) { | |||
| field ??= fieldToFormat(fieldOrDatumDef, expr, normalizeStack); | |||
|
|
|||
| if (isFieldDef(fieldOrDatumDef) && isBinning(fieldOrDatumDef.bin)) { | |||
| if ( | |||
| field !== 'datum.value' && // For axis/legend, we can't correct know the end of the bin from `datum` | |||
There was a problem hiding this comment.
It turns out that this part of the code always trigger crashes if I don't add field !== 'datum.value'
-- see this example
8762532 to
9fa3563
Compare
565f8ab to
3a21d8a
Compare
domoritz
approved these changes
Jun 21, 2022
src/config.ts
Outdated
| @@ -145,10 +145,22 @@ export interface VLOnlyConfig<ES extends ExprRef | SignalRef> { | |||
| fieldTitle?: 'verbal' | 'functional' | 'plain'; | |||
|
|
|||
| /** | |||
| * D3 Number format for guide labels and text marks. For example `"s"` for SI units. Use [D3's number format pattern](https://github.com/d3/d3-format#locale_format). | |||
| * If numberFormatType is not specified or is `"format"`, | |||
There was a problem hiding this comment.
Suggested change
| * If numberFormatType is not specified or is `"format"`, | |
| * If `numberFormatType` is not specified or is `"format"`, |
There was a problem hiding this comment.
I'm very confused by the special string "format" here. Where is this coming from?
|
🚀 PR was released in |
Merged
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
…config.numberFormat` (vega#8228) Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
config.numberFormatTypefor using custom formatter with config.numberFormat (just like there isformatTypeforformat)We can add
timeFormatTypelater, but I think it's hairier so I wanna handle numberFormatType first.You can see that the example added originally treats
1.0as D3's format. (But with the code changes, it now treats1.0as a parameter ofpow.)📦 Published PR as canary version:
5.2.1--canary.8228.a549581.0✨ Test out this PR locally via:
npm install vega-lite@5.2.1--canary.8228.a549581.0 # or yarn add vega-lite@5.2.1--canary.8228.a549581.0