Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: titleFormat -> fieldTitle in compile docs #8202

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Conversation

jkillian
Copy link
Contributor

@jkillian jkillian commented Jun 1, 2022

Just fixing a small typo in the examples in the docs on compile, I think this was just a typo originally that never got caught.

@jkillian jkillian marked this pull request as ready for review June 1, 2022 21:52
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. You also need to update line 59.

@jkillian
Copy link
Contributor Author

jkillian commented Jun 2, 2022

🤦 My apologies, both locations should be fixed now!

@jkillian jkillian requested a review from domoritz June 2, 2022 22:41
@domoritz
Copy link
Member

domoritz commented Jun 3, 2022

No problem. That's what reviews are for. Thanks for the quick update.

@domoritz domoritz merged commit 63641b1 into vega:next Jun 3, 2022
@github-actions
Copy link

🚀 PR was released in v5.3.0-next.4 🚀

@github-actions github-actions bot mentioned this pull request Jun 21, 2022
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants