Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove <null> from Value to fix TopLevelSpec consumed by code using strict mode #7357

Closed
wants to merge 3 commits into from

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Apr 4, 2021

Copy of #7352

@walterra
Copy link
Contributor

walterra commented Apr 6, 2021

Looks like all tests passed! 🥳

Great if there are no changes! Before and after, is there any externally observable change? Can you assign a value that could not be assigned before or vice versa?

The generated spec didn't change and since null was already part of the allowed values as part of PrimitiveValue there should also be no change in how to use the TS interface.

@domoritz domoritz changed the title fix: Remove <null> from Value to fix TopLevelSpec consumed by code using strict mode fix: remove <null> from Value to fix TopLevelSpec consumed by code using strict mode Apr 6, 2021
@domoritz
Copy link
Member Author

domoritz commented Apr 6, 2021

That is not correct.

const v: VgValueRef = {
  value: {signal: 'string'}
};

used to not be allowed and now is

@domoritz domoritz closed this Apr 6, 2021
@domoritz domoritz deleted the pr/walterra/7352 branch April 6, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants