timeUnitBandPosition with escaped field (e.g., "\\'fieldName\\'") doesn't work. #9480
Closed
1 task done
Labels
Comments
yhoonkim
added a commit
that referenced
this issue
Dec 3, 2024
#9479) ## PR Description **Problem** The expression like ``` `datum["${str}"]` ``` which is vulnerable when `str` has double quotes, such as `'hello, "world"'`. The expression with single quotes is the same ``` `datum['${str}']` ``` which is vulnerable when `str` has single quotes, such as `"Vega's Favorite"`. **Solution** This PR fixes the existing datum access expression to have a proper quote escape by calling `accessWithDatumToUnescapedPath` It fixes the issue of timeunit band position transforms which don't escape the field name correctly. #9480 --------- Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
|
Closed by #9479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description
When timeUnitBandPosition is set, the escaped field doesn't work.
{ "$schema": "https://vega.github.io/schema/vega-lite/v5.json", "data": { "values": [{"'temporal'": "2024-01-01", "group": "x", "value": 0.1}] }, "mark": "bar", "encoding": { "x": { "field": "\\'temporal\\'", "type": "temporal", "timeUnit": "utcyearmonthdate" }, "y": {"field": "value", "type": "quantitative"} }, "config": {"bar": {"timeUnitBandPosition": 0}} }It returns the below error:
https://vega.github.io/editor/#/url/vega-lite/N4IgJAzgxgFgpgWwIYgFwhgF0wBwqgegIDc4BzJAOjIEtMYBXAI0poHsDp5kTykBaADZ04JAKyUAVhDYA7EABoQAEySYUqUMSSCGcCGgDaoAOSZEONgCcdJtCABMABgcAWfk4CMHz4pBkrNgYcewAPP21dODQnSk8AXwBdeKVkKwBreyYkKz84WSg2ZRpZMjRQcM0QADMaOEFlewAdJrMLax0WuyVMAE8caPRzBEsbQT9MGgQ4AFVZOnsGTCheuByEOXpVcxAUkF7ymrqG+0i9Cf7BkABHBiRZSfVJ0l29wtlasqrs3KrJ6bmdAAQvdlAAFNgQOjseSoJzxBFAA
Checklist
The text was updated successfully, but these errors were encountered: