Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick should respect "width/height/size": {"band": 0.5} #7724

Open
kanitw opened this issue Sep 27, 2021 · 1 comment
Open

Tick should respect "width/height/size": {"band": 0.5} #7724

kanitw opened this issue Sep 27, 2021 · 1 comment
Assignees
Labels

Comments

@kanitw
Copy link
Member

kanitw commented Sep 27, 2021

Currently the default tick length is fixed no matter what the step size is.

@kanitw kanitw added Bug 🐛 P3 Should be fixed at some point labels Sep 27, 2021
@kanitw kanitw self-assigned this Sep 27, 2021
kanitw added a commit that referenced this issue Nov 2, 2021
@kanitw kanitw removed the P3 Should be fixed at some point label Nov 14, 2023
@kanitw
Copy link
Member Author

kanitw commented Nov 14, 2023

Technically, we now respect step size

{
  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
  "description": "A simple bar chart with embedded data.",
  "data": {
    "values": [
      {"a": "A", "b": 28}, {"a": "B", "b": 55}, {"a": "C", "b": 43},
      {"a": "D", "b": 91}, {"a": "E", "b": 81}, {"a": "F", "b": 53},
      {"a": "G", "b": 19}, {"a": "H", "b": 87}, {"a": "I", "b": 52} 
    ]
  },
  "width": {"step": 50},
  "mark": "tick",
  "encoding": {
    "x": {"field": "a", "type": "nominal", "axis": {"labelAngle": 0}},
    "y": {"field": "b", "type": "quantitative"}
  }
}

but we does not respect "width/height/size": {"band": 0.5} yet

@kanitw kanitw changed the title Tick should respect step size Tick should respect "width/height/size": {"band": 0.5} Nov 14, 2023
kanitw added a commit that referenced this issue Jul 30, 2024
kanitw added a commit that referenced this issue Aug 28, 2024
…nd (#9415)

## PR Description

Make ticks respect bin/timeUnit bands and custom band (by calling
`rectPosition()`, just like rect and bar marks)

See the examples added as a proof for fixing.

---------

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant