Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point mark doesn't work with ordinal bin #7682

Closed
kanitw opened this issue Sep 6, 2021 · 0 comments · Fixed by #7685
Closed

Point mark doesn't work with ordinal bin #7682

kanitw opened this issue Sep 6, 2021 · 0 comments · Fixed by #7685
Assignees
Labels
Bug 🐛 P3 Should be fixed at some point

Comments

@kanitw
Copy link
Member

kanitw commented Sep 6, 2021

{
  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
  "data": {"url": "data/cars.json"},
  "transform": [{"calculate": "random()", "as": "random"}],
  
  "mark": "point",
  "encoding": {
    "x": {"field": "Horsepower","type": "quantitative"},
    "y": {"bin": true, "field": "Miles_per_Gallon","type": "ordinal"}
  }
}

image

@kanitw kanitw added Bug 🐛 P3 Should be fixed at some point labels Sep 6, 2021
@kanitw kanitw self-assigned this Sep 6, 2021
kanitw added a commit that referenced this issue Sep 6, 2021
kanitw added a commit that referenced this issue Sep 7, 2021
kanitw added a commit that referenced this issue Sep 12, 2021
* fix: make point mark work with ordinal bin

fix #7682

* refactor: don't export POSITION_SCALE_CHANNEL_INDEX, use isXorY

* refactor: rename `exprFromValueRefOrSignalRef`

* chore: update examples [CI]

* style: auto-formatting [CI]

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this issue Oct 19, 2023
* fix: make point mark work with ordinal bin

fix vega#7682

* refactor: don't export POSITION_SCALE_CHANNEL_INDEX, use isXorY

* refactor: rename `exprFromValueRefOrSignalRef`

* chore: update examples [CI]

* style: auto-formatting [CI]

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 P3 Should be fixed at some point
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant