-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image on a map: NaN width/height #6580
Comments
It looks like we don't support datum in latitude/longitude yet. However, even if I modify the Vega spec manually (Open the Chart in the Vega Editor), I see NaN for width and height. This needs some more investigation. |
Hm, I believe the same problem still occurs when using Might it be that width/height are simply not converted the right way when a geographical projection is in place? Both should correspond to screen pixels, not degrees (at least that is how it works when used in non-geo markers).. |
Yeah, something is going wrong here. |
Maybe we introduced an issue in #5668. |
Awesome! 👍 Out of curiosity, now that this works: what extra changes would be needed to be able to plot tiles on the map? I assume width and height are now pixel-sized - or is it also possible to express these as (lon, lat) delta? Might as well add that if it is easy, as it would enable using e.g. OSM tiles. |
I think you could do it (someone has done it for Vega already) but the performance isn't great for interactions. You can try it when we make a release. |
When creating a map using Vega-Lite and circle markers, all is well (very pretty!). After changing the marker type to "image", adding "width" and "height" values, as well as adding a "url" encoding, it appears the images that are put on the map do not receive proper width/height.
The same usage of images appears to work fine on regular (non-geo) charts. To reproduce, paste in the online editor:
Result in (most recent) Chrome:
The text was updated successfully, but these errors were encountered: