ci: split scripts and refine triggers (#8356)

* ci: split scripts and refine triggers * ci: run on pr * Use original branch for check jobs * Manually trigger merge * use default refs * Add back branch
vega · Aug 15, 2022 · af53b74 · af53b74
1 parent c91b7c4
commit af53b74
Show file tree

Hide file tree

Showing 9 changed files with 100 additions and 79 deletions.
diff --git a/.github/workflows/check-toc.yml b/.github/workflows/check-toc.yml
@@ -0,0 +1,53 @@
+name: Check
+
+on:
+  workflow_dispatch:
+  pull_request:
+    paths:
+      - 'site/**'
+      - 'scripts/**'
+
+jobs:
+  toc:
+    name: TOC
+    if: "!contains(github.event.head_commit.message, '[ci skip]')"
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          token: ${{ secrets.GH_PAT || github.token }}
+          ref: ${{ github.head_ref }}
+
+      - name: Setup Node
+        uses: actions/setup-node@v3
+        with:
+          cache: 'yarn'
+
+      - name: Install Node dependencies
+        run: yarn --frozen-lockfile
+
+      - name: Setup Ruby
+        uses: actions/setup-ruby@v1
+        with:
+          ruby-version: '2.x'
+
+      - name: Setup data
+        run: yarn data
+
+      - name: Build Jekyll
+        run: |
+          gem install bundler
+          pushd site
+          bundle install
+          bundle exec jekyll build -q
+          popd
+
+      - name: Build TOC
+        run: scripts/generate-toc
+
+      - name: Setup Git remote
+        run: scripts/setup-git-ci.sh
+
+      - name: Check and Commit
+        run: scripts/check-and-commit-toc.sh
diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
@@ -1,9 +1,8 @@
 name: Check
 
 on:
-  push:
-    branches:
-      - '**'
+  workflow_dispatch:
+  pull_request:
 
 jobs:
   check:
@@ -14,6 +13,7 @@ jobs:
       - uses: actions/checkout@v3
         with:
           token: ${{ secrets.GH_PAT || github.token }}
+          ref: ${{ github.head_ref }}
 
       - name: Setup Node
         uses: actions/setup-node@v3
@@ -35,60 +35,16 @@ jobs:
           sudo mv parallel sem /usr/local/bin
 
       - name: Format
-        if: github.ref != 'refs/heads/next'
         run: yarn format
 
       - name: Build Schema
         run: yarn schema
 
       - name: Check Schema
-        run: ./scripts/check-schema.sh
+        run: scripts/check-schema.sh
 
       - name: Setup Git remote
-        run: ./scripts/setup-git-ci.sh
+        run: scripts/setup-git-ci.sh
 
       - name: Check and Commit
-        run: ./scripts/check-and-commit.sh
-
-  toc:
-    name: TOC
-    if: "!contains(github.event.head_commit.message, '[ci skip]')"
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v3
-        with:
-          token: ${{ secrets.GH_PAT || github.token }}
-
-      - name: Setup Node
-        uses: actions/setup-node@v3
-        with:
-          cache: 'yarn'
-
-      - name: Install Node dependencies
-        run: yarn --frozen-lockfile
-
-      - name: Setup Ruby
-        uses: actions/setup-ruby@v1
-        with:
-          ruby-version: '2.x'
-
-      - name: Setup data
-        run: yarn data
-
-      - name: Build Jekyll
-        run: |
-          gem install bundler
-          pushd site
-          bundle install
-          bundle exec jekyll build -q
-          popd
-
-      - name: Build TOC
-        run: scripts/generate-toc
-
-      - name: Setup Git remote
-        run: ./scripts/setup-git-ci.sh
-
-      - name: Check and Commit
-        run: ./scripts/check-and-commit-toc.sh
+        run: scripts/check-and-commit.sh
diff --git a/.github/workflows/merge-dependabot.yml b/.github/workflows/merge-dependabot.yml
@@ -1,7 +1,10 @@
 name: Auto-merge Dependabot PRs
+
 on:
+  workflow_dispatch:
   schedule:
     - cron: '0 * * * *'
+
 jobs:
   auto_merge:
     name: Auto-merge Dependabot PRs

diff --git a/.github/workflows/publish-to-npm.yml b/.github/workflows/publish-to-npm.yml
@@ -7,6 +7,8 @@ on:
       - 'dependabot/**'
       # documentation site should not trigger releases
       - 'gh-pages'
+    paths-ignore:
+      - 'site/**'
 
 jobs:
   publish:

diff --git a/.github/workflows/release-docs-and-schema.yml b/.github/workflows/release-docs-and-schema.yml
@@ -27,7 +27,7 @@ jobs:
         run: yarn build
 
       - name: Setup Git remote
-        run: ./scripts/setup-git-ci.sh
+        run: scripts/setup-git-ci.sh
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
@@ -49,4 +49,4 @@ jobs:
           site-directory: 'site/'
 
       - name: Publish schema
-        run: ./scripts/deploy-schema.sh
+        run: scripts/deploy-schema.sh
diff --git a/.github/workflows/test-docs.yml b/.github/workflows/test-docs.yml
@@ -0,0 +1,31 @@
+name: Test
+
+on:
+  workflow_dispatch:
+  pull_request:
+    paths:
+      - 'site/**'
+      - 'yarn.lock'
+      - '**prettier**'
+
+jobs:
+  build-site:
+    name: Build Site
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Setup Node
+        uses: actions/setup-node@v3
+        with:
+          cache: 'yarn'
+
+      - name: Install Node dependencies
+        run: yarn --frozen-lockfile
+
+      - name: Lint
+        run: yarn prettierbase --check
+
+      - name: Build
+        run: yarn build:site
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -1,10 +1,10 @@
 name: Test
 
 on:
-  push:
-    branches:
-      - next
+  workflow_dispatch:
   pull_request:
+    paths-ignore:
+      - 'site/**'
 
 jobs:
   test:
@@ -31,24 +31,6 @@ jobs:
       - name: Build
         run: yarn build
 
-  build-site:
-    name: Build Site
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@v3
-
-      - name: Setup Node
-        uses: actions/setup-node@v3
-        with:
-          cache: 'yarn'
-
-      - name: Install Node dependencies
-        run: yarn --frozen-lockfile
-
-      - name: Build
-        run: yarn build:site
-
   runtime-lint-coverage:
     name: Runtime, Linting, and Coverage
     runs-on: ubuntu-latest

diff --git a/scripts/check-and-commit-toc.sh b/scripts/check-and-commit-toc.sh
@@ -3,9 +3,6 @@
 set -euo pipefail
 
 GIT_BRANCH="${GITHUB_REF/refs\/heads\//}"
-git checkout $GIT_BRANCH
-
-echo "On branch $GIT_BRANCH."
 
 # Only push on human pull request branches. Exclude release, prerelease, and bot branches.
 if [ "$GIT_BRANCH" != "stable" ] && [ "$GIT_BRANCH" != "next" ] && [[ "$GIT_BRANCH" != dependabot/* ]]; then

diff --git a/scripts/check-and-commit.sh b/scripts/check-and-commit.sh
@@ -3,9 +3,6 @@
 set -euo pipefail
 
 GIT_BRANCH="${GITHUB_REF/refs\/heads\//}"
-git checkout $GIT_BRANCH
-
-echo "On branch $GIT_BRANCH."
 
 # Only push on human pull request branches. Exclude release, prerelease, and bot branches.
 if [ "$GIT_BRANCH" != "stable" ] && [ "$GIT_BRANCH" != "next" ] && [[ "$GIT_BRANCH" != dependabot/* ]]; then