Skip to content

Commit

Permalink
fix: selections should be cleared by events in any view (#7165)
Browse files Browse the repository at this point in the history
* fix: selections should by cleared by events in any view

* chore: update examples [CI]

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
  • Loading branch information
arvind and GitHub Actions Bot authored Jan 7, 2021
1 parent f365e1f commit 9289bb0
Show file tree
Hide file tree
Showing 86 changed files with 271 additions and 277 deletions.
4 changes: 2 additions & 2 deletions examples/compiled/airport_connections.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@
"update": "datum && item().mark.marktype !== 'group' ? {unit: \"layer_2\", fields: org_tuple_fields, values: [(item().isVoronoi ? datum.datum : datum)[\"origin\"]]} : null",
"force": true
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "null"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "null"}
]
},
{"name": "org_tuple_fields", "value": [{"type": "E", "field": "origin"}]},
Expand All @@ -157,7 +157,7 @@
],
"update": "event.shiftKey"
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "false"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "false"}
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/bar_count_minimap.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@
},
{"events": {"signal": "brush_scale_trigger"}, "update": "[0, 0]"},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down
4 changes: 2 additions & 2 deletions examples/compiled/brush_table.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
"update": "[scale(\"concat_0_x\", brush_Horsepower[0]), scale(\"concat_0_x\", brush_Horsepower[1])]"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down Expand Up @@ -190,7 +190,7 @@
"update": "[scale(\"concat_0_y\", brush_Miles_per_Gallon[0]), scale(\"concat_0_y\", brush_Miles_per_Gallon[1])]"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down
4 changes: 2 additions & 2 deletions examples/compiled/circle_bubble_health_income.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
{
"name": "view_income",
"on": [
{"events": [{"source": "scope", "type": "dblclick"}], "update": "null"},
{"events": [{"source": "view", "type": "dblclick"}], "update": "null"},
{
"events": {"signal": "view_translate_delta"},
"update": "panLog(view_translate_anchor.extent_x, -view_translate_delta.x / width)"
Expand All @@ -46,7 +46,7 @@
{
"name": "view_health",
"on": [
{"events": [{"source": "scope", "type": "dblclick"}], "update": "null"},
{"events": [{"source": "view", "type": "dblclick"}], "update": "null"},
{
"events": {"signal": "view_translate_delta"},
"update": "panLinear(view_translate_anchor.extent_y, view_translate_delta.y / height)"
Expand Down
4 changes: 2 additions & 2 deletions examples/compiled/concat_bar_layer_circle.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@
"force": true
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "null"
}
]
Expand All @@ -303,7 +303,7 @@
"update": "event.shiftKey"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "false"
}
]
Expand Down
8 changes: 4 additions & 4 deletions examples/compiled/concat_hover.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"force": true
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "null"
}
]
Expand All @@ -87,7 +87,7 @@
"update": "event.shiftKey"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "false"
}
]
Expand Down Expand Up @@ -201,7 +201,7 @@
"force": true
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "null"
}
]
Expand All @@ -219,7 +219,7 @@
"update": "event.shiftKey"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "false"
}
]
Expand Down
8 changes: 4 additions & 4 deletions examples/compiled/concat_hover_filter.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"force": true
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "null"
}
]
Expand All @@ -114,7 +114,7 @@
"update": "event.shiftKey"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "false"
}
]
Expand Down Expand Up @@ -241,7 +241,7 @@
"force": true
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "null"
}
]
Expand All @@ -259,7 +259,7 @@
"update": "event.shiftKey"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "false"
}
]
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/interactive_area_brush.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"update": "[scale(\"x\", brush_yearmonth_date[0]), scale(\"x\", brush_yearmonth_date[1])]"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down
8 changes: 4 additions & 4 deletions examples/compiled/interactive_bar_select_highlight.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"update": "datum && item().mark.marktype !== 'group' ? {unit: \"\", fields: highlight_tuple_fields, values: [(item().isVoronoi ? datum.datum : datum)[\"_vgsid_\"]]} : null",
"force": true
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "null"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "null"}
]
},
{
Expand All @@ -78,7 +78,7 @@
"events": [{"source": "scope", "type": "mouseover"}],
"update": "event.shiftKey"
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "false"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "false"}
]
},
{
Expand All @@ -98,7 +98,7 @@
"update": "datum && item().mark.marktype !== 'group' ? {unit: \"\", fields: select_tuple_fields, values: [(item().isVoronoi ? datum.datum : datum)[\"_vgsid_\"]]} : null",
"force": true
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "null"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "null"}
]
},
{
Expand All @@ -113,7 +113,7 @@
"events": [{"source": "scope", "type": "click"}],
"update": "event.shiftKey"
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "false"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "false"}
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/compiled/interactive_bin_extent.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
"update": "[scale(\"concat_0_x\", brush_time[0]), scale(\"concat_0_x\", brush_time[1])]"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down
4 changes: 2 additions & 2 deletions examples/compiled/interactive_brush.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"update": "[scale(\"x\", brush_Horsepower[0]), scale(\"x\", brush_Horsepower[1])]"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down Expand Up @@ -141,7 +141,7 @@
"update": "[scale(\"y\", brush_Miles_per_Gallon[0]), scale(\"y\", brush_Miles_per_Gallon[1])]"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down
4 changes: 2 additions & 2 deletions examples/compiled/interactive_concat_layer.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@
"force": true
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "null"
}
]
Expand All @@ -317,7 +317,7 @@
"update": "event.shiftKey"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "false"
}
]
Expand Down
8 changes: 4 additions & 4 deletions examples/compiled/interactive_dashboard_europe_pop.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@
},
{"events": {"signal": "brush_scale_trigger"}, "update": "[0, 0]"},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down Expand Up @@ -727,7 +727,7 @@
},
{"events": {"signal": "brush_scale_trigger"}, "update": "[0, 0]"},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down Expand Up @@ -1051,7 +1051,7 @@
"update": "[scale(\"concat_2_x\", brush_Population_ages_65_and_above_of_total[0]), scale(\"concat_2_x\", brush_Population_ages_65_and_above_of_total[1])]"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down Expand Up @@ -1110,7 +1110,7 @@
"update": "[scale(\"concat_2_y\", brush_Population_ages_15_64_of_total[0]), scale(\"concat_2_y\", brush_Population_ages_15_64_of_total[1])]"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down
8 changes: 4 additions & 4 deletions examples/compiled/interactive_global_development.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
"update": "datum && item().mark.marktype !== 'group' ? {unit: \"layer_1_layer_1\", fields: hovered_tuple_fields, values: [(item().isVoronoi ? datum.datum : datum)[\"country\"]]} : null",
"force": true
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "null"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "null"}
]
},
{
Expand All @@ -174,7 +174,7 @@
"events": [{"source": "scope", "type": "mouseover"}],
"update": "event.shiftKey"
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "false"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "false"}
]
},
{
Expand All @@ -194,7 +194,7 @@
"update": "datum && item().mark.marktype !== 'group' ? {unit: \"layer_1_layer_1\", fields: clicked_tuple_fields, values: [(item().isVoronoi ? datum.datum : datum)[\"country\"]]} : null",
"force": true
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "null"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "null"}
]
},
{
Expand All @@ -209,7 +209,7 @@
"events": [{"source": "scope", "type": "click"}],
"update": "event.shiftKey"
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "false"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "false"}
]
},
{
Expand Down
4 changes: 2 additions & 2 deletions examples/compiled/interactive_index_chart.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"update": "datum && item().mark.marktype !== 'group' ? {unit: \"layer_0\", fields: index_tuple_fields, values: [(item().isVoronoi ? datum.datum : datum)[\"date\"]]} : null",
"force": true
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "null"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "null"}
]
},
{
Expand All @@ -143,7 +143,7 @@
],
"update": "event.shiftKey"
},
{"events": [{"source": "scope", "type": "dblclick"}], "update": "false"}
{"events": [{"source": "view", "type": "dblclick"}], "update": "false"}
]
},
{
Expand Down
6 changes: 3 additions & 3 deletions examples/compiled/interactive_layered_crossfilter.vg.json
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@
"update": "[scale(\"child__column_distance_x\", brush_distance[0]), scale(\"child__column_distance_x\", brush_distance[1])]"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down Expand Up @@ -620,7 +620,7 @@
"update": "[scale(\"child__column_delay_x\", brush_delay[0]), scale(\"child__column_delay_x\", brush_delay[1])]"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down Expand Up @@ -995,7 +995,7 @@
"update": "[scale(\"child__column_time_x\", brush_time[0]), scale(\"child__column_time_x\", brush_time[1])]"
},
{
"events": [{"source": "scope", "type": "dblclick"}],
"events": [{"source": "view", "type": "dblclick"}],
"update": "[0, 0]"
},
{
Expand Down
Loading

0 comments on commit 9289bb0

Please sign in to comment.