[DRAFT] chore: set up auto for versioning/release management #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c7b661f to
e3127d1
Compare
|
@kristw is maintaining this repo so I will let him decide how we wants to handle things. |
74cd718 to
4fdc694
Compare
…version in actions build: enable lerna automation tokens to run with correct permissions build: use explicit node version build: swtich publishConfig from .org to .com build: include NPM token in addition to auth token build: include NPM token in addition to auth token build: use npm set to modify lerna publish credentials
4fdc694 to
1504252
Compare
|
Appreciate the effort in adding automation. Let me take some time to read through. |
|
Given the complications that arose with Auto in the future ( see vega/vega-lite#8370 ), I think it is best if we close this PR for now. If we revisit automatic releases in the future, we may be better off using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Request from @domoritz as part of the Vega org-wide automation effort. Note this is the first time we're applying auto to a Monorepo (with multiple yarn workspaces) in 1 repo in the Vega org, but it's possible (see this repo for reference).
See vega/vega-lite#7984 for a similar PR.
Changes
Pre-merge checklist for a repo admin
nextfrom the current head ofmasterhttps://github.com/vega/react-vega/tree/nextnextthe base branch of this PR instead ofmasternextthe base branch for the whole repostablefrom the latest tagv7.5.1https://github.com/vega/react-vega/tree/stableskip-releaseandreleasedin this repo (the first is used to tell auto not to release anything if this PR is released, the second is used to tag PRs that have been released).📦 Published PR as canary version:
7.5.2--canary.497.1504252.0✨ Test out this PR locally via:
npm install react-vega@7.5.2--canary.497.1504252.0 # or yarn add react-vega@7.5.2--canary.497.1504252.0