-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: make vega_datasets accessible from alt.datasets #872
Conversation
I'm still about 50/50 on this change... or maybe 60/40 in favor.
|
You might want to also mention somewhere in the documentation (in case that's not already mentioned) that for these data to be available, users should install On the other hand If you don't, users will get that message on the first time they refer to |
All the installation instructions list |
You're probably right, but to be on the safe side, in case someone shows up in the examples, instead of this page, I would add something like "Some of these examples also require an installation of |
Whoops. Sorry about the noise! |
Jake, I am fine either way on this one
…--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com
|
Having slept on this a bit, I think I'd prefer not to wrap datasets into altair. |
Addresses #796
This makes the contents of
vega_datasets
available from Altair viaalt.datasets
. So, for example, you can do:If the vega_datasets package is not installed, an error will be raised when you try to access a dataset, but not when you import the
alt.datasets
object (which is present in the main namespace)