Mpl #8
Merged
Mpl #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellisonbg
added a commit
that referenced
this pull request
Sep 19, 2015
binste
added a commit
to binste/altair
that referenced
this pull request
Apr 15, 2023
…a. Changes are not relevant as we upgrade to 5.7 anyway. They happened as part of resolving vega/schema vega#8
joelostblom
pushed a commit
that referenced
this pull request
Apr 25, 2023
* Add comments to existing tests what the errors are in the chart specification. Relevant as sometimes only one is shown in the resulting error message * Refactor validate_jsonschema into smaller functions * Add new way of prioritizing errors. Group them by path to offending element before passing to SchemaValidationError to allow for better error messages to be created * Remove whitespaces in blank line * Make error attribute private * Add tests for datum and value * Add type hints to help with refactoring * Refactor creation of error message as preparation for handling multiple errors * First draft for showing all distinct errors * Type hint validate_jsonschema * Add correct error message to attribute of SchemaValidationError * Remove unnecessary deduplication in schemavalidationerror which now already happens in validate_jsonschema * Remove _get_all_lowest_errors_with_validator * Add PR to changelog. Only show one line for error message improvements in changelog * Remove indentation in error messages which had to be removed with inspect.cleandoc. This makes it easier to work on the error messages * Use f string instead of format * Reorder methods in calling order * Refactor _get_message_for_errors * Improve error messages for multiple errors about the same instance * Move call of _get_altair_class_for_error into _get_message_for_errors * Add docstrings * Minor refactoring * Format code * Enumerate error messages. Don't separate by line as unclear how long it should be as this depends on the frontend * Add more test examples * Harmonize chart_error_example function names * Somehow the VL 5.6.1 schema changed slightly. Including the changes here as we upgrade to 5.7 anyway before a release * Revert "Somehow the VL 5.6.1 schema changed slightly. Including the changes here as we upgrade to 5.7 anyway before a release" This reverts commit 09805a3. * Remove # in front of error number * Add 'Multiple errors were found.' as a first line if multiple errors are found * Indent error messages from the second line onwards if multiple errors are shown * Show a maximum of 3 errors * Some white spaces were removed in a description in the VL 5.6.1 schema. Changes are not relevant as we upgrade to 5.7 anyway. They happened as part of resolving vega/schema #8 * Minor improvements * Revert minor change * re-run generate_schema_wrapper.py * Capitalize bullet points --------- Co-authored-by: Mattijn van Hoek <mattijn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.