Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Make skip_requires_pyarrow compatible w/ pytest.param #3772

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

dangotbanned
Copy link
Member

Originally added in e1290d4

Trying to reduce the size of #3631.
This change is atomic and useful enough on its own.

Example

requires_pyarrow: pytest.MarkDecorator = skip_requires_pyarrow()
backends: pytest.MarkDecorator = pytest.mark.parametrize(
"backend",
[
"polars",
pytest.param(
"pandas",
marks=pytest.mark.xfail(
find_spec("pyarrow") is None,
reason=(
"`pandas` supports backends other than `pyarrow` for `.parquet`.\n"
"However, none of these are currently an `altair` dependency."
),
),
),
pytest.param("pandas[pyarrow]", marks=requires_pyarrow),
pytest.param("pyarrow", marks=requires_pyarrow),
],
)

Originally added in e1290d4

Try to reduce the size of #3631. This change is atomic and useful enough on its own
@dangotbanned dangotbanned enabled auto-merge (squash) January 16, 2025 15:26
@dangotbanned dangotbanned merged commit f45dcfb into main Jan 16, 2025
25 checks passed
@dangotbanned dangotbanned deleted the test-skip-pyarrow-typing branch January 16, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant