Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump narwhals to v1.14.2 #3697

Merged
merged 3 commits into from
Nov 23, 2024
Merged

chore: bump narwhals to v1.14.2 #3697

merged 3 commits into from
Nov 23, 2024

Conversation

mattijn
Copy link
Contributor

@mattijn mattijn commented Nov 23, 2024

This PR updates pyproject.toml to update narwhals to v1.14.2.
Note: v1.14.2 is not yet on conda-forge (https://anaconda.org/conda-forge/narwhals/files)

@mattijn mattijn changed the title chore(deps) bump narwhals to v1.14.2 chore: bump narwhals to v1.14.2 Nov 23, 2024
@MarcoGorelli
Copy link
Contributor

hey - just a quick note to clarify that I don't think the bump is strictly required - the code in Altair works perfectly fine as-is, this bump would only be necessary if you wanted to do

from narwhals.stable.v1.dependencies import is_pandas_dataframe
if is_pandas_dataframe(data):
    ...

instead of

import narwhals.stable.v1 as nw
if nw.dependencies.is_pandas_dataframe(data):
    ...

@dangotbanned
Copy link
Member

hey - just a quick note to clarify that I don't think the bump is strictly required - the code in Altair works perfectly fine as-is, this bump would only be necessary if you wanted to do

from narwhals.stable.v1.dependencies import is_pandas_dataframe
if is_pandas_dataframe(data):
    ...

instead of

import narwhals.stable.v1 as nw
if nw.dependencies.is_pandas_dataframe(data):
    ...

@MarcoGorelli that's what I wanted to do in my PR but @mattijn beat me to it 😅

@mattijn
Copy link
Contributor Author

mattijn commented Nov 23, 2024

Thanks @MarcoGorelli, good to know that current situation is fine as is. Will leave this PR open until @dangotbanned finds time to implements these new feature possibilities.

@dangotbanned
Copy link
Member

Thanks @MarcoGorelli, good to know that current situation is fine as is. Will leave this PR open until @dangotbanned finds time to implements these new feature possibilities.

Doing this now @mattijn thank you

@dangotbanned dangotbanned enabled auto-merge (squash) November 23, 2024 19:05
@dangotbanned dangotbanned added maintenance dependencies Pull requests that update a dependency file labels Nov 23, 2024
@dangotbanned dangotbanned merged commit b6481d2 into main Nov 23, 2024
25 checks passed
@dangotbanned dangotbanned deleted the bump-narwhals branch November 23, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants