Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use pass_through instead of strict in narwhals.from_native, use stable.v1 API more #3693

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Nov 22, 2024

I'm addressing the API mix noted in #3690

Also, seeing as 1.13.1 is now the minimum, you can now use pass_through instead of strict (https://narwhals-dev.github.io/narwhals/backcompat/#after-stablev1)

@MarcoGorelli MarcoGorelli changed the title chore: use pass_through instead of strict in narwhals.from_native, use stable.v1 API more chore: Use pass_through instead of strict in narwhals.from_native, use stable.v1 API more Nov 22, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review November 22, 2024 18:03
@dangotbanned
Copy link
Member

@MarcoGorelli do you know if we could use a ruff rule for the narwhals imports?

If we had something like this, but suggesting the stable.v1 path it would be quite handy

altair/pyproject.toml

Lines 393 to 400 in 936c0af

[tool.ruff.lint.flake8-tidy-imports.banned-api]
# https://docs.astral.sh/ruff/settings/#lint_flake8-tidy-imports_banned-api
"typing.Optional".msg = """
Use `Union[T, None]` instead.
`typing.Optional` is likely to be confused with `altair.typing.Optional`, \
which have a similar but different semantic meaning.
See https://github.com/vega/altair/pull/3449
"""

altair/utils/core.py Outdated Show resolved Hide resolved
altair/utils/core.py Outdated Show resolved Hide resolved
Copy link
Member

@dangotbanned dangotbanned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @MarcoGorelli

@dangotbanned dangotbanned merged commit c41e29e into vega:main Nov 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants