Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(typing): Resolve warnings in test_api.py #3592

Merged
merged 5 commits into from
Sep 15, 2024
Merged

test(typing): Resolve warnings in test_api.py #3592

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb737c5
fix(typing): Resolve strange decorator/reserved keyword interaction
dangotbanned Sep 15, 2024
d7a1e82
fix(typing): Check for `Undefined` in `test_selection`
dangotbanned Sep 15, 2024
760c222
fix(typing): Check for unicode/bytes
dangotbanned Sep 15, 2024
3946d02
chore(typing): Ignore `LookupData.data` warning, add `api.py` comment
dangotbanned Sep 15, 2024
e1344ed
fix: Use `pyright`-specific ignore
dangotbanned Sep 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 28 additions & 9 deletions tests/vegalite/v5/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,12 +805,16 @@ def test_save(format, engine, basic_chart):
if format == "json":
assert "$schema" in json.loads(content)
elif format == "html":
assert isinstance(content, str)
assert content.startswith("<!DOCTYPE html>")
elif format == "svg":
assert isinstance(content, str)
assert content.startswith("<svg")
elif format == "png":
assert not isinstance(content, (str, bytearray, memoryview))
assert content.startswith(b"\x89PNG")
elif format == "pdf":
assert not isinstance(content, (str, bytearray, memoryview))
assert content.startswith(b"%PDF-")

fid, filename = tempfile.mkstemp(suffix="." + format)
Expand Down Expand Up @@ -942,14 +946,20 @@ def test_facet_parse_data():
def test_selection():
# test instantiation of selections
interval = alt.selection_interval(name="selec_1")
assert interval.param.select.type == "interval"
param = interval.param
assert isinstance(param, alt.SelectionParameter)
select = param.select
assert isinstance(select, alt.IntervalSelectionConfig)
assert select.type == "interval"
assert interval.name == "selec_1"

single = alt.selection_point(name="selec_2")
assert isinstance(single.param, alt.SelectionParameter)
assert single.param.select.type == "point"
assert single.name == "selec_2"

multi = alt.selection_point(name="selec_3")
assert isinstance(multi.param, alt.SelectionParameter)
assert multi.param.select.type == "point"
assert multi.name == "selec_3"

Expand All @@ -976,8 +986,8 @@ def test_selection():

def test_transforms():
# aggregate transform
agg1 = alt.AggregatedFieldDef(**{"as": "x1", "op": "mean", "field": "y"})
agg2 = alt.AggregatedFieldDef(**{"as": "x2", "op": "median", "field": "z"})
agg1 = alt.AggregatedFieldDef(op="mean", field="y", **{"as": "x1"})
agg2 = alt.AggregatedFieldDef(op="median", field="z", **{"as": "x2"})
chart = alt.Chart().transform_aggregate([agg1], ["foo"], x2="median(z)")
kwds = {"aggregate": [agg1, agg2], "groupby": ["foo"]}
assert chart.transform == [alt.AggregateTransform(**kwds)]
Expand Down Expand Up @@ -1070,19 +1080,26 @@ def test_transforms():
# stack transform
chart = alt.Chart().transform_stack("stacked", "x", groupby=["y"])
assert chart.transform == [
alt.StackTransform(stack="x", groupby=["y"], **{"as": "stacked"})
alt.StackTransform(
groupby=["y"],
stack="x",
offset=Undefined,
sort=Undefined,
**{"as": "stacked"},
)
]

# timeUnit transform
chart = alt.Chart().transform_timeunit("foo", field="x", timeUnit="date")
kwds = {"as": "foo", "field": "x", "timeUnit": "date"}
assert chart.transform == [alt.TimeUnitTransform(**kwds)]
assert chart.transform == [
alt.TimeUnitTransform(field="x", timeUnit="date", **{"as": "foo"})
]

# window transform
chart = alt.Chart().transform_window(xsum="sum(x)", ymin="min(y)", frame=[None, 0])
window = [
alt.WindowFieldDef(**{"as": "xsum", "field": "x", "op": "sum"}),
alt.WindowFieldDef(**{"as": "ymin", "field": "y", "op": "min"}),
alt.WindowFieldDef(field="x", op="sum", param=Undefined, **{"as": "xsum"}),
alt.WindowFieldDef(field="y", op="min", param=Undefined, **{"as": "ymin"}),
]

# kwargs don't maintain order in Python < 3.6, so window list can
Expand Down Expand Up @@ -1218,7 +1235,9 @@ def test_selection_property():

def test_LookupData():
df = nw.from_native(pd.DataFrame({"x": [1, 2, 3], "y": [4, 5, 6]}))
lookup = alt.LookupData(data=df, key="x")
# Data type hints won't match with what TopLevelUnitSpec expects
# as there is some data processing happening when converting to a VL spec
lookup = alt.LookupData(data=df, key="x") # pyright: ignore[reportArgumentType]

dct = lookup.to_dict()
assert dct["key"] == "x"
Expand Down