Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Unstack area to render cumulative chart correctly #3558

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

joelostblom
Copy link
Contributor

This has likely been broken since Vega-Lite changed the default behavior in
https://github.com/vega/vega-lite/releases/tag/v5.14.1

You can see the current broken chart here https://altair-viz.github.io/gallery/cumulative_count_chart.html

After this PR:
image

@dangotbanned
Copy link
Member

So in vega/vega-lite#9170 the change is quite obvious.

Screenshot

image

However in this example, I'm having a hard time understanding the visual difference between the two.

I'm assuming the font change is unrelated, but that is all I can see.

User Guide This PR

image

image

Vega Editor (stack:true)

Vega Editor (stack:false)


Am I missing something that stands out to you?

@joelostblom
Copy link
Contributor Author

Oh, I had to rerun the command to update the webpage and forgot that I had already done these changes locally when I did that. So these PR updates are now accidentally already included in the built docs. You can see that the change suggested in the PR is already there in the code and if I run the code without stack(False) I see this (which is how the docs looked up until I rebuilt the doc web site):

image

@joelostblom
Copy link
Contributor Author

joelostblom commented Aug 27, 2024

I'm curious about the font change you are observing. To me, all the chart fonts in the docs look like the right most figure (arial-like sans serif font), but it seems like you are seeing a monospace font by default, is this the case for you with all the figures in the docs?

It also seems like the blue hue is slightly different in your screenshots compared to mine.

@dangotbanned
Copy link
Member

I'm curious about the font change you are observing. To me, all the chart fonts in the docs look like the right most figure (arial-like sans serif font), but it seems like you are seeing a monospace font by default, is this the case for you with all the figures in the docs?

The font seems to be a contribution from a browser extension I'm using to enforce a constant monospace font within codeblocks on documentation websites.
I think I need to update the CSS to exclude whatever altair-plot ends up displaying in.

I'm seeing the same font as you when browsing the examples on my phone

@dangotbanned
Copy link
Member

Oh that is incredibly clear in #3558 (comment)

I spent far too long doubting myself trying to figure out what changed 😅

Copy link
Member

@dangotbanned dangotbanned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelostblom joelostblom merged commit aeb0c72 into main Aug 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants