chore: Remove filterwarnings from tests for cross-version pandas compatibility #3522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas has two month-related offsets:
When doing a monthly group-by, I think the first one gives the results that people are usually actually looking for, and is the same across versions, hence removing the need for filterwarnings or version checks
In the
bump_chart.py
example:'6MS'
means that the windows are:I think the former is a much more natural way of thinking about time series, and so is better suited to the examples anyway (in addition to helping avoid
filterwarnings
Output:
before
after
Due to the explanation above, I think the second one would align more closely without how people would read the chart