Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add python-version=="3.9" to github action #3498

Merged
merged 2 commits into from
Jul 24, 2024
Merged

ci: Add python-version=="3.9" to github action #3498

merged 2 commits into from
Jul 24, 2024

Conversation

dangotbanned
Copy link
Member

Addresses one item in #3497

This one is a pretty minor fix, and could be added now - since eventually it will be the lower bound.

@dangotbanned dangotbanned mentioned this pull request Jul 23, 2024
Closed
joelostblom
joelostblom approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think it makes sense to have 3.9 here, especially since 3.8 will soon be EOL as you mentioned

@joelostblom joelostblom merged commit 781c507 into vega:main Jul 24, 2024
13 checks passed
@dangotbanned dangotbanned deleted the add-py39-build-matrix branch July 24, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelostblom joelostblom joelostblom approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dangotbanned @joelostblom