Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Remove outdated comments about the use of the former _Parameter protocol #3448

Merged
merged 1 commit into from
Jun 27, 2024
Merged

style: Remove outdated comments about the use of the former _Parameter protocol #3448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions altair/vegalite/v5/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,6 @@ def _get_channels_mapping() -> dict[type[SchemaBase], str]:
class Parameter(_expr_core.OperatorMixin):
"""A Parameter object"""

# NOTE: If you change this class, make sure that the protocol in
# altair/vegalite/v5/schema/core.py is updated accordingly if needed.

_counter: int = 0

@classmethod
Expand Down
8 changes: 3 additions & 5 deletions tools/schemapi/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,11 +336,9 @@ def get_python_type_representation(
class_names = ["SchemaBase"]
if self.title == "ExprRef":
# In these cases, a value parameter is also always accepted.
# We use the _Parameter to indicate this although this
# protocol would also pass for selection parameters but
# due to how the Parameter class is defined, it would be quite
# complex to further differentiate between a value and
# a selection parameter based on the type system (one could
# It would be quite complex to further differentiate
# between a value and a selection parameter based on
# the type system (one could
# try to check for the type of the Parameter.param attribute
# but then we would need to write some overload signatures for
# api.param).
Expand Down