-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add example interactive aggregation #3260
Conversation
Thanks for putting this together! Love that you also added the constant size scale and filtered out the aggregate points from the view. Some nits that don't block the PR but are worth considering:
|
Thanks for the review @dwootton! I think the current approach is in line what you describe. See also Open the Chart in the Vega Editor. Agreed? |
This is really cool! Thank you both :) Just one small comment, should one filter statement include the actual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example is really neat, love it!
), | ||
|
||
alt.Chart().mark_rule(color="gray").encode( | ||
strokeWidth=alt.StrokeWidth(value=6), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice use of the new syntax we just discovered =) We should probably document this somewhere eventually and decide on one to favor in the docs, but that's another issue.
Thanks for the reviews! Especially thanks to @dwootton for exploring this type of interactive visualizations (and sharing these with the world!👍) |
This PR adds a new example showing interactive aggregation. The example is heavily inspired by this example by @dwootton.
@dwootton, I modified your example a little bit, could you review the introduced changes? I'm not sure if my changes make the goal of the chart more intuitive.