Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: examples: remove connected_scatterplot #3159

Merged

Conversation

NickCrews
Copy link
Contributor

Caused by
#3156 (comment)

I move over the reference to the NYTimes
article because I think that is valuable.

@mattijn
Copy link
Contributor

mattijn commented Aug 19, 2023

Tests are failing because of this line:

https://github.com/altair-viz/altair/blob/main/tests/test_transformed_data.py#L25

Can you update this test to reflect the new file?

Caused by
vega#3156 (comment)

I move over the reference to the NYTimes
article because I think that is valuable.
@NickCrews NickCrews force-pushed the fixup-remove-connected-scatterplot-example branch from f49c615 to 8071fd8 Compare August 19, 2023 03:25
Copy link
Contributor

@mattijn mattijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @NickCrews

@mattijn mattijn merged commit 12478f6 into vega:main Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants