Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vega-Lite to 5.14.1. Add transform_extent #3148

Merged
merged 11 commits into from
Aug 13, 2023

Conversation

binste
Copy link
Contributor

@binste binste commented Aug 12, 2023

So far there were no changes to Altair necessary apart from rerunning the automatic code generation. For the tests to pass, we need a new version of vl-convert with support for VL 5.14.1. @jonmmease Would that work for you? I think even if a new VL version comes out in the next 1-2 weeks, although I'm not aware of one, we could still stick to VL 5.14.1 for Altair 5.1.

See #3145 (comment) for the related release discussion.

@jonmmease
Copy link
Contributor

Thanks for working on this @binste! Yes, I'll get a vl-convert update out shortly

@jonmmease
Copy link
Contributor

jonmmease commented Aug 12, 2023

Vega-Lite 5.14.1 added to vl-convert-python in version 0.12.0 (just released)

Update: I restarted the tests to see if that fixes the issue

@jonmmease
Copy link
Contributor

I don't know if it actually introduces any challenges, but the new extent transform is a bit unique in that it's a transform that outputs a param.

From https://vega.github.io/vega-lite/docs/extent.html, it looks like the param is provided as just a string, so I guess that should work fine in Altair as well. It doesn't need to be this PR, but we should make a note that we need to add a new extent transform section to the docs, and it would be good to port over the example from https://vega.github.io/vega-lite/docs/extent.html.

@binste
Copy link
Contributor Author

binste commented Aug 13, 2023

Thanks for making a new release of vl-convert and the feedback! Good point about extent, I missed that one when going through the release logs.

I'll add it in this PR in the coming days

  • transform_extent method in api.py
  • Doc page
  • Test in test_transforms
  • Add to changes.rst

@binste binste changed the title Update Vega-Lite to 5.14.1 Update Vega-Lite to 5.14.1. Add transform_extent Aug 13, 2023
@binste
Copy link
Contributor Author

binste commented Aug 13, 2023

Implemented transform_extent method and added a new page to the documentation.

@binste binste marked this pull request as ready for review August 13, 2023 10:40
@@ -96,6 +97,7 @@ Transform Supported
:ref:`user-guide-bin-transform` ✔
:ref:`user-guide-calculate-transform` ✔
:ref:`user-guide-density-transform`
:ref:`user-guide-extent-transform`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonmmease Does VegaFusion support the extent transform? The .transformed_data method worked on the chart example I built in the doc page but as I use the parameter value as single values it does not return it anyway so not sure if that's a good test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, VegaFusion supports extent, so I think we're good there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I'll add the tick in the docs

Copy link
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling all of this together, and adding the new docs for extent. lgtm!

@binste binste merged commit 9a6f39c into vega:main Aug 13, 2023
@binste
Copy link
Contributor Author

binste commented Aug 13, 2023

Thanks for the review! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants