Handle pyarrow-backed columns in pandas 2 DataFrames #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it raises an exception, return False
|
Based on review in #3127 will merge this. Thanks again @jonmmease and @sacundim! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3127
pandas 2.0 introduced optional pyarrow dtype integration (See https://pandas.pydata.org/docs/user_guide/pyarrow.html). Altair's DataFrame sanitization logic was broken in two ways for these DataFrames.
np.issubdtypefunction raises an exception when passed a pyarrow dtype (rather than just returnFalse).This PR adds a previously failing test case and handles these two issues.