-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vega-v5 wrappers #2822
Remove vega-v5 wrappers #2822
Conversation
Can you check @joelostblom? I think I removed everything related to the Vega wrapper, but I might have missed some parts in the docs/docstring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for doing this. Apart from one of the deleted tests I think this looks good. I grepped the repo for "vega" and didn't notice any other places needing an update.
I noticed the name of the branch and just wanted to say that I think it makes sense to have a separate PR for removing the old Vega-Lite versions and limiting this PR to Vega as you have done now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misread the test I thought was accidentally deleted, this looks good.
One thing I was thinking here is that maybe we should add an explicit note in the docs that Altair specs can programmatically be turned into VegaLite with |
This PR removes the Vega V5 wrappers from the Altair repository.
It removes them from the generate_schema_wrapper, magics, mimebundle, tests and docs.
Not everything related to vega is removed since the saving utilities requires vega bundles to be included.