-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move tests and sphinxext outside folder application code #2792
Conversation
@binste, can you have a look if this is OK? All tests now also pass on Github Actions including building the docs. I think this is a nice improvement. Then after this we can merge the test-file changes from https://github.com/altair-viz/altair/pull/2770/files into a folder |
Agree, this is a great improvement to the package structure, thanks @mattijn! Could you also update the pytest commands in https://github.com/altair-viz/altair/blob/master/Makefile? Apart from that it looks good to me. I also built the documentation locally and all examples rendered fine. |
Thanks for the feedback @binste. I updated the makefile, I also had to add the |
First attempt for #2788.
This also moves the sphinxext folder to the main folder.
All tests pass locally.
description what happens in this PR.
altair.examples
totests/examples_arguments_syntax
altair
intotests
folder, keeping the same folder structure how these test files appeared.altair.sphinxext
folder tosphinxext
folder on main leveltests
folder instead ofaltair
folderpytest-cov
package todependencies_dev.txt
file, so the coverage functions also function in theMakefile
iter_examples
toiter_examples_arguments_syntax
pyproject.toml
andsetup.cfg
to exclude the tests folder