-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: add discussion of dates & times in Altair #1087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concerns about this behavior based on my experience with datetime64 in NumPy/pandas.
Where would be the right place to raise these concerns -- here or in some upstream Vega repo?
reflecting the user's local time, Safari treats them as | ||
`Coordinated Universal Time (UTC)`_. The result is that when viewed in Safari, | ||
visualized dates will differ from their inputs due to a time zone correction, | ||
unless you explicitly use UTC (see :ref:`explicit-utc-time`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this include the case of timezone naive datetimes? They get interpreted as UTC and then displayed in local time? Or do they get interpreted and displayed both in UTC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, timezone naive times are what Altair uses by default. They are interpreted and displayed as local times by every browser except Safari, which treats them as UTC and then displays them as local time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes, that's pretty bad!
You're right. I made the assumption based on my previous comment #1053 (comment), but that one was written in Altair 2.1. Current version behaves as you've written. |
No description provided.