Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add discussion of dates & times in Altair #1087

Merged
merged 3 commits into from
Aug 13, 2018

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Aug 13, 2018

No description provided.

@jakevdp jakevdp merged commit f844225 into vega:master Aug 13, 2018
@jakevdp jakevdp deleted the timezone-doc branch August 13, 2018 21:12
@jakevdp jakevdp mentioned this pull request Aug 13, 2018
13 tasks
Copy link

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some concerns about this behavior based on my experience with datetime64 in NumPy/pandas.

Where would be the right place to raise these concerns -- here or in some upstream Vega repo?

reflecting the user's local time, Safari treats them as
`Coordinated Universal Time (UTC)`_. The result is that when viewed in Safari,
visualized dates will differ from their inputs due to a time zone correction,
unless you explicitly use UTC (see :ref:`explicit-utc-time`)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this include the case of timezone naive datetimes? They get interpreted as UTC and then displayed in local time? Or do they get interpreted and displayed both in UTC?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, timezone naive times are what Altair uses by default. They are interpreted and displayed as local times by every browser except Safari, which treats them as UTC and then displays them as local time.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, that's pretty bad!

@mattijn
Copy link
Contributor

mattijn commented Aug 22, 2018

You're right. I made the assumption based on my previous comment #1053 (comment), but that one was written in Altair 2.1. Current version behaves as you've written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants