Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: add Python 3.7 support; remove Python 3.4 support #1008

Merged
merged 2 commits into from
Aug 27, 2018

Conversation

jakevdp
Copy link
Collaborator

@jakevdp jakevdp commented Jul 9, 2018

No description provided.

@jakevdp
Copy link
Collaborator Author

jakevdp commented Jul 9, 2018

Will revisit when 3.7 support is figured out in Travis/

@jakevdp
Copy link
Collaborator Author

jakevdp commented Jul 12, 2018

Blocking issue is here: travis-ci/travis-ci#9815

@jakevdp
Copy link
Collaborator Author

jakevdp commented Aug 10, 2018

OK, got it working now... but because Python 3.7 requires a sudo=True build, it roughly quadruples the build time (from ~1.5 minutes to ~6 minutes.

I don't think it's worth that added cost at the moment. I'm going to hold-off on 3.7 support for the time being.

@jakevdp jakevdp closed this Aug 10, 2018
@jakevdp jakevdp deleted the 3.7 branch August 10, 2018 19:59
@jakevdp jakevdp restored the 3.7 branch August 10, 2018 19:59
@hugovk
Copy link
Contributor

hugovk commented Aug 27, 2018

I tried this branch and 3.7 errored after about 3 minutes:

3.7 is not installed; attempting download
Downloading archive: https://s3.amazonaws.com/travis-python-archives/binaries/ubuntu/16.04/x86_64/python-3.7.tar.bz2
$ curl -sSf -o python-3.7.tar.bz2 ${archive_url}
curl: (7) Failed to connect to s3.amazonaws.com port 443: Connection timed out
Unable to download 3.7 archive. The archive may not exist. Please consider a different version.

The curl command took 1m41s on my machine.

Rebuilding, 3.7 passed and took 1m33s (second fastest of them all):
https://travis-ci.org/hugovk/altair/jobs/420965493

Triggering a second build, 3.7 took 1m08s (the fastest):
https://travis-ci.org/hugovk/altair/builds/420967211

Triggering a third build, 3.7 took 1m19s (fastest again):
https://travis-ci.org/hugovk/altair/builds/420967441

I'm guessing perhaps there's some caching going on which may be slow first time round.

I suggest giving the PR another chance! :)

@hugovk
Copy link
Contributor

hugovk commented Aug 27, 2018

And as it happens, my 3.5 build for #1120 happened to take 4m55s. Looks like that was also an occasional slow download of the Python archive.

https://travis-ci.org/hugovk/altair/builds/420969335

@jakevdp
Copy link
Collaborator Author

jakevdp commented Aug 27, 2018

Thanks - I'll take a look!

@jakevdp jakevdp reopened this Aug 27, 2018
@jakevdp
Copy link
Collaborator Author

jakevdp commented Aug 27, 2018

Rebased on master... we'll see if the builds are better now.

@jakevdp
Copy link
Collaborator Author

jakevdp commented Aug 27, 2018

Seems to be OK – thanks @hugovk!

@jakevdp jakevdp merged commit d043e8b into vega:master Aug 27, 2018
@jakevdp jakevdp deleted the 3.7 branch August 27, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants