-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: add Python 3.7 support; remove Python 3.4 support #1008
Conversation
Will revisit when 3.7 support is figured out in Travis/ |
Blocking issue is here: travis-ci/travis-ci#9815 |
OK, got it working now... but because Python 3.7 requires a sudo=True build, it roughly quadruples the build time (from ~1.5 minutes to ~6 minutes. I don't think it's worth that added cost at the moment. I'm going to hold-off on 3.7 support for the time being. |
I tried this branch and 3.7 errored after about 3 minutes:
The curl command took 1m41s on my machine. Rebuilding, 3.7 passed and took 1m33s (second fastest of them all): Triggering a second build, 3.7 took 1m08s (the fastest): Triggering a third build, 3.7 took 1m19s (fastest again): I'm guessing perhaps there's some caching going on which may be slow first time round. I suggest giving the PR another chance! :) |
And as it happens, my 3.5 build for #1120 happened to take 4m55s. Looks like that was also an occasional slow download of the Python archive. |
Thanks - I'll take a look! |
Rebased on master... we'll see if the builds are better now. |
Seems to be OK – thanks @hugovk! |
No description provided.